Fix vanilla no async manager #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
async doesn't exist outside of coldbox so this ensures it won't try to split uploads and then fail when asyncManager is undefined.
jclausen
requested changes
Aug 21, 2024
| @@ -800,7 +800,12 @@ component accessors="true" singleton { | |||
| arguments.contentType = getFileMimeType( arguments.filepath ); | |||
| } | |||
|
|
|||
| var byteCount = getFileInfo( arguments.filepath ).size; | |||
| var byteCount = 0; | |||
| if( structKeyExists( variables, "asyncManager" ) ) { | |||
There was a problem hiding this comment.
Let's allow multi-part uploads when AsyncManager is null ( e.g. outside Coldbox/CommandBox context ). So, in the try/catch block for the multipart, we can do:
var processPart = function( part ){
var channel = part.channel.position( part.offset );
var buffer = createObject( "java", "java.nio.ByteBuffer" ).allocate( part.limit );
channel.read( buffer );
return {
"partNumber" : part.partNumber,
"size" : part.limit,
"channel" : part.channel,
"response" : s3Request(
method = "PUT",
resource = bucketName & "/" & uri,
body = buffer.array(),
timeout = part.timeout,
parameters = {
"uploadId" : part.uploadId,
"partNumber" : part.partNumber
},
headers = { "content-type" : "binary/octet-stream" }
)
};
};
if( !isNull( variables.asyncManagers ) ){
variables.asyncManager.allApply( parts, processPart );
} else {
parts = parts.map( processPart );
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove dependency on async manager which doesn't outside of coldbox, without this a large upload would fail when this.asyncManager is undefined.